Improve quick note editor interactions & fix filter chips responsiveness#964
Open
ishaanxgupta wants to merge 8 commits into
Open
Improve quick note editor interactions & fix filter chips responsiveness#964ishaanxgupta wants to merge 8 commits into
ishaanxgupta wants to merge 8 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 4873082 | May 21 2026, 09:52 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 4873082 | Commit Preview URL Branch Preview URL |
May 21 2026, 09:53 AM |
ishaanxgupta
changed the title
|
Claude finished @ishaanxgupta's task in 1m 37s —— View job Review Complete
Overview: Replaces the QuickNoteCard textarea with the TipTap TextEditor for consistent editing experience (including slash commands), adds expand/collapse behavior based on focus and content, and makes filter chips horizontally scrollable on mobile. Issues found: None — this looks good to ship. The implementation is solid:
Score: 10/10 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: Replaces the QuickNoteCard textarea with the TipTap TextEditor for consistent editing experience (including slash commands), adds expand/collapse behavior based on focus and content, and makes filter chips horizontally scrollable on mobile.
Issues found: None — this looks good to ship.
The implementation is solid:
- The
draftRefpattern inquick-note-card.tsxcorrectly ensures the submit callback always has the latest draft value without stale closure issues - The content sync effect in
text-editor/index.tsxproperly compares serialized content to avoid resetting the editor while the user is typing - The
editableprop is correctly synced viasetEditable()effect - Focus/blur handlers for expand/collapse behavior properly check
e.currentTarget.contains(e.relatedTarget)to prevent collapsing on internal focus changes - The CSS changes for responsive filter chips are straightforward layout adjustments
Score: 10/10
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The editorHeight variable was defined but never used. Now it's applied to the TextEditor container div. Also fixed formatting to match biome expectations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On phone, the filter chips now get their own horizontally scrollable row, so All, Notes, Tweets, Web Pages, and any future connection chips can fit without squeezing. The Grid / Timeline segmented control stays grouped on the next row and aligned to the right.
The QuickNoteCard now uses the same TipTap TextEditor as the full-screen note, so typing / should show the slash-command options like headings. It also expands from 120px to 188px when focused or when it has draft content, then collapses again on blur if empty.
I also updated TextEditor so it can be used inline safely: it now supports editable={false} while saving, and it syncs external content resets without constantly resetting the editor while typing.